Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added postfix and dovecot for fail2ban #476

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

Spitfireap
Copy link
Member

Not tested yet.

@codecov
Copy link

codecov bot commented Feb 9, 2023

Codecov Report

Base: 50.07% // Head: 50.07% // No change to project coverage 👍

Coverage data is based on head (3113eaf) compared to base (63d92b7).
Patch has no changes to coverable lines.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #476   +/-   ##
=======================================
  Coverage   50.07%   50.07%           
=======================================
  Files          10       10           
  Lines         681      681           
=======================================
  Hits          341      341           
  Misses        340      340           
Impacted Files Coverage Δ
modoboa_installer/config_dict_template.py 100.00% <ø> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@Spitfireap Spitfireap marked this pull request as ready for review February 10, 2023 14:24
@xinomilo
Copy link

xinomilo commented Mar 21, 2024

port 587 , can also be written as "submission". so you could use :
"default": "http,https,pop3,pop3s,imap,imaps,submission"
( just for the looks of it, doesn't make any difference :) )

also filter names in jail.d/[doveot|postfix].conf should be "dovecot-modoboa" and "postfix-modoboa"

edit] actually, filters dovecot-modoboa.conf and postfix-modoboa.conf are identical with fail2ban defaults dovecot.conf and postifx.conf, so maybe those are not needed at all.. just use fail2ban defaults (?)
(compared to filters shipped with fail2ban 0.11.2-2 in Debian 11.9)

@almereyda
Copy link
Contributor

The [postfix], [modoboa] and [dovecot] sections all specify the same ports = %ports_blocked setting.

It may be good to split ports_blocked into dedicated constants for postfix_ports_blocked (smtps,submission), modoboa_ports_blocked (http,https) and dovecot_ports_blocked (pop3,pop3s,imap,imaps). This could help not setting ports on applications which don't effectively use them.

Since RFC 8314 the SMTPS port 465 with implicit TLS is the default MTA entrypoint. This means smtps would have to be added to postfix_ports_blocked.

Further I agree to use the default, packaged configuration files and remove them here, if they are not to be altered.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants